On 2008/11/27 00:33, Marc Pavot <[EMAIL PROTECTED]> wrote: > It is based on your repository and I have done one commit to continue the > split of libmpdclient. > It creates three new files: connection, idle and return_element. The > separation is not perfect (for example some structures and methods in > connection will have to become private in the future) but it's a first > brick.
Thanks, it's merged. I have some suggestions: - I saw that your idle patch introduced inconsistent indentation (e.g. mpd_glibStartIdle); please configure your editor to indent with tabs. - A commit should include a brief one-line description, followed by an empty line, and a longer description following. This way, stuff like "git shortlog" works properly. Don't write another description in the email - a well-documented patch doesn't need further explanation. - set "local" includes first, to test if the include file has specified its own dependencies properly, i.e. include "idle.h" before <stdio.h> and <string.h> in idle.c. In return_element.c you did this very well: "return_element.h" before "str_pool.h" (str_pool.h was already checked by str_pool.c). Max ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
