On 2009/03/01 10:47, Jochen Keil <jochen.k...@gmail.com> wrote:
> I figured with the prefix the files get sorted in a correct order.. but
> this is cosmetical and should be configurable as soon as we have cue
> sheet support.

MPD *should* sort by track number (see songvec.c, songvec_sort()), and
only revert to comparing the file name if there's no track number.  So
if your sub-tracks have the correct TAG_ITEM_TRACK values, MPD should
be ok.

> So we would have two new api extensions:
> sub_decode() and scan_directory()?
> That's ok for me and i'll implement it that way.

Yes.  Give it a more beautiful and uniform name.  Maybe sub_scan() and
sub_decode().  "sub" was a bad choice, because in the media player
world, "sub" usually means "subtitles" for a video...  Think something
up, or leave it ugly for now, it's internal API only, we can change it
at any time.

> We could make the scan_directory() method point to the flac_cue_track()
> method and extend the the tag_dup method to tag the (virtual) files
> accordingly.
> That way the code would be separated i think and the includes shouldn't
> be necessary anymore.

Sounds good.

> Hm.. i think it would be a bit hard for me but i got used to C the last
> weeks so it could be done i guess (also it'd take some time..).
> The more general problem is that i do not really have a clue about
> writing a parser. I figured to make something like a fixed size hash
> table according to the entrys (like "PERFORMER", "TRACK", etc.) and then
> have a linked list with entrys attached to the table (similar to
> separate chaining).
> But maybe there's a whole different "general" approach to parsing i am
> not aware of.

Do something which is easy to implement now (I'll try to help).

> There are some good parts which could be used but the parser itself
> is written in yacc/bison which i don't "speak". :)

Ugh.  No, thanks.

By the way, get yourself a git account:

 http://git.musicpd.org/account-policy.html

Max

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Reply via email to