Gert Driesen wrote:

...

- what should happen, if referenced fileset have another basedir ?
- what should happen, if exclude/include of 2 filesets conflicts ?
- is every possible combination of those covered in test cases?
For mine use, I dont combine basedirs and dont use excludes at all, but
those problems should be solved. I feel, this is main problem why this
extension wasnt incorporated yet. Maybe we could discuss it now...

I agree, these problems should be resolved before we introduce this feature.

I agree, too. Otherwise it will be impossible to test and chaos around the expected results will ensue.

I'm tempted to include it and let people have a play with it and then
refine it as necessary rather than holding out until its perfect. What
do people think ?

I'd rather have a more general approach, where all global types implement
support for merging two distinct instances.


Is this meaningful for all types? Or just those that are collections? Does it make sense, for example, to talk about merging two proxies?

Also, I'm not sure if this is something we should introduce this late in the
game.

I am sure - it's not. Once a release candidate has gone out the door, with the intent of a final release soon thereafter, only bug fixes should go in. No feature requests, enhancements, etc. Sometimes there's a gray area as to whether something is a bug fix or an enhancement, but I think this is clearly the latter.

Gary





-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
nant-developers mailing list
nant-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nant-developers

Reply via email to