Peter Memishian writes: > I agree it's a wart, but I think "contort" is blowing it out of proportion > -- it's a single consolidation-private flag to dlpi_open(), and three > tests of this flag -- in 1400 lines of code) to short-circuit some logic > the libdlpi implementation. The libdlpi API and implementation is in no > way damaged by this wart -- and I certainly prefer the 11 additional lines > of code in libdlpi to the 200+ lines of gnarly getmsg()/putmsg() logic > we'd have to dump back into the sync* commands.
It'd serve them right. > If someone wants to reimplement the serial stuff to not use DL_ATTACH_REQ, > I would certainly welcome it -- and would gladly remove DLPI_SERIAL. But > that's not this project. OK. I'll update CR 4842175 in anticipation. > > The hackish way to fix this is to look at the real node, readlink(), > > and parse out the actual instance number, then use that for > > DL_ATTACH_REQ. The right way to fix it is to get rid of the pseudo > > node junk. > > Agreed. Doing the readlink() crud though is not made appreciably harder > by libdlpi though -- you'd just do that prior to calling dlpi_open(), and > adjust the "linkname" accordingly. "ew" -- James Carlson, KISS Network <[EMAIL PROTECTED]> Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ networking-discuss mailing list [email protected]
