ddanielr commented on code in PR #4746:
URL: https://github.com/apache/accumulo/pull/4746#discussion_r1688467115
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -175,8 +177,9 @@ public ServiceEnvironment getServiceEnv() {
private static CompactionDispatcher
createCompactionDispatcher(AccumuloConfiguration conf,
ServerContext context, TableId tableId) {
- CompactionDispatcher newDispatcher =
Property.createTableInstanceFromPropertyName(conf,
- Property.TABLE_COMPACTION_DISPATCHER, CompactionDispatcher.class,
null);
+ CompactionDispatcher newDispatcher =
+ Property.createTableInstanceFromPropertyName(conf,
Property.TABLE_COMPACTION_DISPATCHER,
+ CompactionDispatcher.class, new SimpleCompactionDispatcher());
if (newDispatcher == null) {
Review Comment:
If we return the default implementation instead of `null` then this logging
code will never be hit.
If the goal is to preserve existing functionality, then we could return a
`new SimpleCompactionDispatcher()` on line 189.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
