ddanielr commented on code in PR #4746:
URL: https://github.com/apache/accumulo/pull/4746#discussion_r1688474557
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -144,7 +146,7 @@ public ParsedIteratorConfig
getParsedIteratorConfig(IteratorScope scope) {
private static ScanDispatcher createScanDispatcher(AccumuloConfiguration
conf,
ServerContext context, TableId tableId) {
ScanDispatcher newDispatcher =
Property.createTableInstanceFromPropertyName(conf,
- Property.TABLE_SCAN_DISPATCHER, ScanDispatcher.class, null);
+ Property.TABLE_SCAN_DISPATCHER, ScanDispatcher.class, new
SimpleScanDispatcher());
Review Comment:
There's a nice logging block in the compactionDispatcher code that logs an
error if null.
Not sure if that also exists in the `createScanDispatcher` method.
The only thing we want to avoid is somehow returning the default class due
to a transient classloader issue and then having the same problem where the
default class is referenced by the Deriver and it cannot be updated without
changing the property value to a non-standard value to trigger the class reload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
