LiteSun commented on code in PR #12347:
URL: https://github.com/apache/apisix/pull/12347#discussion_r2157921129


##########
.github/workflows/check-changelog.yml:
##########
@@ -0,0 +1,24 @@
+name: Check Changelog
+
+on:
+  push:

Review Comment:
   > I'm wondering if we should just listen for changes in the CHANGEsLOG file?
   
   we actually need to detect any missing changelog updates as early as 
possible when a PR is created. I just tested it and found that the push event 
does not trigger the CI when the PR is first submitted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to