eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500133320
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -231,7 +310,7 @@ const ViewResultsModalTrigger = ({
<Button
buttonStyle="primary"
buttonSize="small"
- onClick={closeModal}
+ onClick={() => setShowModal(false)}
Review Comment:
thanks for catching! Yes, I removed the `closeModal` method in one of the
iterations and forgot to put it back here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
