eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500106059
##########
superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx:
##########
@@ -123,7 +123,7 @@ export default function ErrorAlert({
{!isExpandable && !description && (
<span
role="button"
- tabIndex={0}
+ tabIndex={-1}
Review Comment:
Even when navigating to the element, there were no onKeyDown handlers, so
you wouldn't be able to do anything after you tabbed to the element, so I
removed the ability to tab, because it was out of scope, but I just added the
error modal tab functionality since I was here. :)
https://github.com/apache/superset/assets/5186919/6141f4da-c474-47ba-a64e-9bc652b072ec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
