eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500108280
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -170,25 +182,91 @@ const dropdownIconsStyles = css`
}
`;
+export const handleDropdownNavigation = (
+ e: React.KeyboardEvent<HTMLElement>,
+ dropdownIsOpen: boolean,
+ menu: React.ReactElement,
+ toggleDropdown: () => void,
+ setSelectedKeys: (keys: string[]) => void,
+) => {
+ if (e.key === NAV_KEYS.tab && !dropdownIsOpen) {
Review Comment:
Here's the expected behavior: if you are tabbing through the page and you
are on the slice controls and hit tab when the dropdown is not open, you should
jump to the next element in the page instead of interacting with the dropdown
elements. So, I think `&&` is right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
