bito-code-review[bot] commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3732858489
##########
superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx:
##########
@@ -57,6 +57,9 @@ export interface AceCompleterKeywordData {
meta: string;
docText?: string;
docHTML?: string;
+ // The label Ace displays in the autocomplete popup and passes back to
+ // `insertMatch`; may differ from `value`, the text actually inserted.
+ caption?: string;
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to consolidate the interface definitions is
technically sound for long-term maintenance, as it eliminates redundancy.
However, given that this duplication is pre-existing and the current PR is
focused on a specific fix, it is reasonable to defer this refactoring to a
separate task to avoid scope creep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
