mikebridge commented on PR #44028: URL: https://github.com/apache/superset/pull/44028#issuecomment-5765636619
@richardfogaca could you take a final look at `71bd20686495f31879162343d3623eb0f94ba821`? The latest push adds the membership-level copy regression and typing/docstring cleanup. The REST 422 handling and live-nonmember fail-closed behavior from your earlier review remain covered. I also checked Bito's empty-body concern through the authenticated endpoint: empty/null titles, with and without chart duplication, return the FAB fallback message; details are in [the thread reply](https://github.com/apache/superset/pull/44028#discussion_r4064711407). Independent final review passed, and CI has completed with no failures on this head. Ready for re-review and merge once the required approval is in place. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
