man, 08 02 2010 kl. 15:56 +0100, skrev José Luis García Pallero:
> El día 7 de febrero de 2010 23:23, Søren Hauberg <[email protected]> escribió:
> > 1. Make the code available somewhere and announce it on this list.
> > Somebody will then have a look at your code. We have this step
> > for all new contributors.
>
> Hello,
> I have uploaded a copy of the package in
> http://www.mat.ucm.es/~joseluig/descargas/octproj_src.tar.gz
I had a quick look and your package installs just fine. I do have a few
comments:
1. You use 'const_cast' in the C++ code. Is this really necessary?
It is a dangerous thing to do...
2. The INDEX file should only list functions that the user is meant
to call. Is the user meant to call the functions that start with
'_'?
Otherwise, I think things look good. Could you send me your sourceforge
username (if you don't have one, please create one) such that I can give
you access to SVN?
Søren
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Octave-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/octave-dev
