El día 9 de febrero de 2010 09:47, David Grundberg <[email protected]> escribió:
> Søren Hauberg wrote:
>> I had a quick look and your package installs just fine. I do have a few
>> comments:
>>
>> 1. You use 'const_cast' in the C++ code. Is this really necessary?
>> It is a dangerous thing to do...
>> 2. The INDEX file should only list functions that the user is meant
>> to call. Is the user meant to call the functions that start with
>> '_'?
>>
>> Otherwise, I think things look good. Could you send me your sourceforge
>> username (if you don't have one, please create one) such that I can give
>> you access to SVN?
1. See below
2. I think that the user can call the functions stating with '_' in
order to improve speed, because they not check for input arguments. I
think that the differences are well explained in *.pdf overview
> You can use fortran_vec () instead of data ().
Fixed
> Also, warning and error take printf-va_arg arguments. You can do
>
> warning("Projection error in point %d (index starts at
> 1)",
> i+1);
>
> instead of
>
> sprintf(auxErrorText,
> "Projection error in point %d (index starts at
> 1)",
> i+1);
> //warning
> warning(auxErrorText);
>
> Here to help,
> David
>
Fixed
I have uploaded the corrected version
http://www.mat.ucm.es/~joseluig/descargas/octproj_src.tar.gz
My sourceforge user is jgpallero
--
*****************************************
José Luis García Pallero
[email protected]
(o<
/ / \
V_/_
Use Debian GNU/Linux and enjoy!
*****************************************
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Octave-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/octave-dev
