On Sunday 05 November 2006 06:14, Nick S-A wrote: > > With the lack of feedback I'm gonna assume the design is fine or just > > uninteresting. So therefore I was thinking about commiting this > > stuff to svn. > > My suggestion for location is under rtl/video_out_test. Any other > > suggestion? > > That is fine with me. maybe rtl/test_video_out so that all our test > modules are alphabetically printed together. One could make the same > argument with wanting to have all the video_out code alphabetically > printed together, so it doesn't really matter which one we choose, as > long as we choose one and stick with it for all our test modules. > It's commited under rtl/test_video_out now.
> > Nicholas, let me know if you think there is something missing or > > that I could > > have done better. > > Looks fine, but there are two things it is lacking: > 1) It might be nice to have a trivial Makefile so that you just can > type make analog; make test; gimp analog.ppm or whatever. Perhaps with: > a. analog, testing analog output. > b. digital, testing digital output. > c. both, testing both of them. > d. debug, which builds the VCD file, > e. and test, for running the chosen mode. > I'd be happy to write this if you want me to, it should take about a > minute. Yep, go ahead and do that. > 2) It does not support multiple output frames. This doesn't really > matter as much as the Makefile right now, but it is nice to have once > we get into more complicated test cases, or if it is integrated into > Bochs and the like. > If you can get it to work that would be great. As I mentioned in my previous mail I couldn't get iverilog working with non-constant filenames. > The files are also missing licenses at the top, with author, etc. > I added something like that, feel free to add yourself where you feel you've contributed. > Besides that, the code itself runs great! I am glad to see we finally > got a version worthy of commit. > > > nick Yep, me too! Simon _______________________________________________ Open-graphics mailing list [email protected] http://lists.duskglow.com/mailman/listinfo/open-graphics List service provided by Duskglow Consulting, LLC (www.duskglow.com)
