On 06/12/2018 12:59 PM, Wenlin Kang wrote: > On 2018年06月12日 16:01, Richard Leitner wrote: > > Hi Richard > >> Hi Wenlin, >> as we clarified the "one -dbg package per recipe" thing I have some >> comments on the patch itself. >> >> >> On 06/07/2018 11:24 AM, Wenlin Kang wrote: >>> One recipe should only have one -dbg package, because OE only picks >>> up all .debug file into the last one -dbg package listed in variable >>> PACKAGES. >> May you please include a reference to that statement from "Ross Burton"? > > What about changing the comments as below: > > openjdk-8: remove redunant FILES_${PN}-dbg > > One recipe should only have one -dbg package, because OE only picks > up all .debug file into the last one -dbg package listed in variable > PACKAGES. > > Comments(oe-core's commit a3b000643898d7402b9e57c02e8d10e677cc9722) from > Ross Burton as below: > "meta: more removals of redunant FILES_${PN}-dbg > > In some recipes overly-split -dbg packages were merged into PN-dbg. Unless > there's a very good reason, recipes should have a single -dev and -dbg > package. > "
That's fine with me. > >> >>> Signed-off-by: Wenlin Kang <wenlin.k...@windriver.com> >>> --- >>> recipes-core/openjdk/openjdk-8_16xbyy.bb | 10 +++------- >>> 1 file changed, 3 insertions(+), 7 deletions(-) >>> >>> diff --git a/recipes-core/openjdk/openjdk-8_16xbyy.bb >>> b/recipes-core/openjdk/openjdk-8_16xbyy.bb >>> index dd0ed1d..1d7d794 100644 >>> --- a/recipes-core/openjdk/openjdk-8_16xbyy.bb >>> +++ b/recipes-core/openjdk/openjdk-8_16xbyy.bb >>> @@ -14,7 +14,6 @@ do_install() { >>> } >>> PACKAGES_append = " \ >>> - ${PN}-demo-dbg \ >>> ${PN}-demo \ >>> ${PN}-source \ >>> " >>> @@ -47,12 +46,6 @@ FILES_${PN}-dbg_append = "\ >>> ${JDK_HOME}/jre/lib/${JDK_ARCH}/headless/.debug/ \ >>> ${JDK_HOME}/jre/lib/${JDK_ARCH}/xawt/.debug/ \ >>> ${JDK_HOME}/jre/lib/${JDK_ARCH}/client/.debug/ \ >>> -" >>> - >>> -FILES_${PN}-demo = " ${JDK_HOME}/demo ${JDK_HOME}/sample " >>> -RDEPENDS_${PN}-demo = " ${PN} " >>> - >>> -FILES_${PN}-demo-dbg = "\ >>> ${JDK_HOME}/demo/jvmti/gctest/lib/.debug/ \ >>> ${JDK_HOME}/demo/jvmti/heapTracker/lib/.debug/ \ >>> ${JDK_HOME}/demo/jvmti/heapViewer/lib/.debug/ \ >>> @@ -64,6 +57,9 @@ FILES_${PN}-demo-dbg = "\ >>> ${JDK_HOME}/demo/jvmti/compiledMethodLoad/lib/.debug/ \ >>> " >> AFAIK as all ".debug" are included in the -dbg packages it should >> be fine if you remove the whole FILES_${PN}-dbg_append definition. > > I have tested it, that's OK after remove the whole FILES_${PN}-dbg_append > definition. > > Do you mean that we should also remove FILES_${PN}-dbg_append? As there is AFAIK no reason to keep it... Yes please! thanks®ards;Richard.L -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel