On 06/12/2018 02:02 PM, Wenlin Kang wrote: > On 2018年06月12日 19:35, Wenlin Kang wrote: >> On 2018年06月12日 19:09, Richard Leitner wrote: >>> Hi Wenlin, >>> >>> On 06/07/2018 11:24 AM, Wenlin Kang wrote: >>>> We need remove previous debuglink before add it if it has existed, >>>> because it may have a different file name with this that we will add. >>> I'm sorry but I don't get the reason why we need this... >>> It would be great if you may please explain it in a little more detail for >>> me ;-) >> >> Hi Richard >> >> In openjdk-8, its debug file is xxx.debuginfo, and when execute openjdk's >> makefile, it will add >> libjvm.debuginfo as libjvm.so's debuglink section's file name, this name is >> different with that >> we will add in splitdebuginfo() of package.bbclass, this makes we can't get >> symbol information >> when debug libjvm.so in gdb. >> > > When a executable file or library file has contained the debuglink section, > it will not be changed when added again, > so we must remove it after add new one. > > In OE-core, debug file name is the same with the executable file or library > file. >
Thank you for that explanation! Maybe you can add this (or a shortened version of it) to the commit message. Otherwise this patch is fine with me. So please send a v2 of this series whenever you like! regards;Richard.L -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
