http://defect.opensolaris.org/bz/show_bug.cgi?id=19221

Jens Elkner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |.de

--- Comment #4 from Jens Elkner <[email protected]> 2012-07-04 
17:42:41 UTC ---
(In reply to comment #2)
> The fix is simple: use getResourceFile() to get the file object instead of
> constructing the full path using escaped file name.

I'm not sure, whether this works for all repos. Basically the request looks
like http://$site/$webapp/diff/$resourceFile?r1=$fileA@$revA&r2=$fileB@$revB

If your fix works for all repo types, the params $fileA and $fileB
(filepath[i]) would be redundant...

But there is more: Actually I thought, request.getParameter() already decodes
values. If so, the request generation might be bogus. Otherwise all
getParameters() calls+context needs to be checked, whether decoding is needed.
At least java doc says nothing about decoding - need to fetch the specs ...

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev

Reply via email to