http://defect.opensolaris.org/bz/show_bug.cgi?id=19221
--- Comment #11 from Jens Elkner <[email protected]> 2012-07-11 07:20:06 UTC --- (In reply to comment #10) > (In reply to comment #9) ... > diff --git a/web/history.jsp b/web/history.jsp Yes. The value attribute should not contain encoded values, that's the real cause of the problem. However, using path instead of rp may work, because file moves are not tracked yet (but at least wrt. Mercurial it should be possible). So fixing this makes the previous changes to PageConfig wrt. diff/filepath obsolete, which are wrong anyway (just need a little bit time to show a real example, why ;-)). > However, this is not a end of all troubles. There is a corner case bug which > prevents this from working for the first changeset of the file. Yes. Tried your first example - this hit another bug ;-) ... > $ echo "ugh" > foo\:bar > $ hg commit -m "third" > With above fix in history.jsp this works fine when diffing the 2nd and 3rd > changeset. You used >> for 2nd and 3rd instead of > , correct? > Howerver, it does not work when diffing 1st and 2nd changeset (or > 1st and 3rd), resulting in the 'Diffs for binary files cannot be displayed!' > error message. I guess you hit the bug: http://src.iws.cs.ovgu.de/source/xref/opengrok/src/org/opensolaris/opengrok/analysis/AnalyzerGuru.java#455 http://src.iws.cs.ovgu.de/source/xref/opengrok/src/org/opensolaris/opengrok/analysis/plain/PlainAnalyzerFactory.java#55 So a priori files with a size < 4 are always treated as binaries and ascii files with a size < 8 are also assumed to be binaries, because the '\0' char is not in the range accepted by the PlainAnalyzerFactory ... > Also, clicking on the revision ID displays the file contents for 2nd and 3rd > changeset but not the 1st, resulting in 'Binary file [Click here to download]' > (which is moreover badly formatted because it is actually displayed below the > footer). Yes, same thing - no analyzer and thus no genre found ... -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ opengrok-dev mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
