http://defect.opensolaris.org/bz/show_bug.cgi?id=19221
Jens Elkner <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXINSOURCE | --- Comment #5 from Jens Elkner <[email protected]> 2012-07-08 08:15:18 UTC --- Tried to verify it by creating+modifying a testdata/sources/bug19221/test:file.txt in a opengrok test repo. History/diffs work as expected. The only problem encountered is IMHO a browser bug: seem to interpret this relative path as an URI with schema 'test', even so there is no ':/'. Anyway, that's easy to fix by just prefixing the link with a './' - browsers will normalize the URL (checked for FF/Chrome/Safari), i.e. strip './' off in the request... Having a closer look at it, I'm convinced, that the fix is wrong. If one wants to handle it really correctly, the $resourceFile shouldn't be involved at all: what matters are the params only, because there is no guarantee that $fileA@revN and fileB@revM both have the same genre or have the same genre as the current $resourceFile has... Furthermore the fix prevents comparing more or less unrelated files, e.g. if a file has been moved to a different dir ... PS: Had a look at servlet 3.0 specs: it doesn't mention, that one needs to decode getParameter*() values, just says "the value of a request parameter as a String...". This and because decoding is explicitly is mentioned where needed, implies to me, that our getParameter() usage is correct, decoding values once more would be wrong. -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ opengrok-dev mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
