http://defect.opensolaris.org/bz/show_bug.cgi?id=19221
--- Comment #12 from Vladimir Kotal <[email protected]> 2012-07-11 08:42:02 UTC --- (In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #9) > ... > > diff --git a/web/history.jsp b/web/history.jsp > > Yes. The value attribute should not contain encoded values, that's the real > cause of the problem. However, using path instead of rp may work, because file > moves are not tracked yet (but at least wrt. Mercurial it should be possible). > > So fixing this makes the previous changes to PageConfig wrt. diff/filepath > obsolete, which are wrong anyway (just need a little bit time to show a real > example, why ;-)). Yes, I will go ahead with this jsp fix. > > However, this is not a end of all troubles. There is a corner case bug which > > prevents this from working for the first changeset of the file. > > Yes. Tried your first example - this hit another bug ;-) > ... > > $ echo "ugh" > foo\:bar > > $ hg commit -m "third" > > > With above fix in history.jsp this works fine when diffing the 2nd and 3rd > > changeset. > > You used >> for 2nd and 3rd instead of > , correct? Yes, I did. > > Howerver, it does not work when diffing 1st and 2nd changeset (or > > 1st and 3rd), resulting in the 'Diffs for binary files cannot be displayed!' > > error message. > > I guess you hit the bug: > http://src.iws.cs.ovgu.de/source/xref/opengrok/src/org/opensolaris/opengrok/analysis/AnalyzerGuru.java#455 > http://src.iws.cs.ovgu.de/source/xref/opengrok/src/org/opensolaris/opengrok/analysis/plain/PlainAnalyzerFactory.java#55 We arrived with Lubos to the same conclusion yesterday, he has a fix ready. I filed bug 19228 to track it. -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ opengrok-dev mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
