http://defect.opensolaris.org/bz/show_bug.cgi?id=19221
--- Comment #9 from Vladimir Kotal <[email protected]> 2012-07-10 12:21:18 UTC --- (In reply to comment #8) > (In reply to comment #7) > > <snip> > > > Jul 10, 2012 1:38:07 PM org.opensolaris.opengrok.web.PageConfig getDiffData > > WARNING: filepath: 1 = /colon-test/foo%3Abar > > Jul 10, 2012 1:38:07 PM org.opensolaris.opengrok.web.PageConfig getDiffData > > WARNING: filepath: 2 = /colon-test/foo%3Abar > > > > > > So, the URL is certainly not fully decoded. > > Actually the decoding was done correctly. The source was foo%253Abar which is > 'foo' + percent character + '3A' + 'bar' so the result was foo%3Abar. Is this > maybe a problem with double encoding ? The table generated by history.jsp has this: <form action="/source/diff/colon-test/foo%3Abar"> <table class="src" id="revisions"> <caption>History log of <a href="/source/xref/colon-test/foo%3Abar">/colon-test/foo:bar</a></caption> <thead> <tr> <th>Revision</th> <th><input type="submit" value=" Compare "/></th> <th>Date</th> <th>Author</th> <th>Comments </th> </tr> </thead> <tbody> <tr> <td><a name="1:d4dce3491f92" href="/source/xref/colon-test/foo%3Abar?r=1%3Ad4dce3491f92">1:d4dce3491f92</a></td> <td> <input type="radio" disabled="disabled" name="r1" value="/colon-test/foo%3Abar@1:d4dce3491f92"/> <input type="radio" name="r2" checked="checked" value="/colon-test/foo%3Abar@1:d4dce3491f92"/></td> <td>10-Jul-2012</td> <td><a href="http://www.opensolaris.org/[email protected]";>Vladimir Kotal <[email protected]></a></td> <td>second<span class="filelist-hidden"><br/></span></td> </tr> <tr> <td><a name="0:6293c321ce21" href="/source/xref/colon-test/foo%3Abar?r=0%3A6293c321ce21">0:6293c321ce21</a></td> <td> <input type="radio" checked="checked" name="r1" value="/colon-test/foo%3Abar@0:6293c321ce21"/> <input type="radio" name="r2" value="/colon-test/foo%3Abar@0:6293c321ce21"/></td> <td>10-Jul-2012</td> <td><a href="http://www.opensolaris.org/[email protected]";>Vladimir Kotal <[email protected]></a></td> <td>first<span class="filelist-hidden"><br/></span></td> </tr> </tbody> </table> </form> The values are of interest, for example this one: value="/colon-test/foo%3Abar@0:6293c321ce21" It contains 'foo:bar' with the colon already encoded. However, the colon which is part of the Merucial changeset ID is not encoded. The encoding (done when hitting the Compare button ?) converts the percent character to '%25' and leaves the '3A' intact, hence resulting in 'foo%253Abar'. -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ opengrok-dev mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
