Hi,
Wow! I barely hit return on my email and the patch was in my
inbox!! :-)
I made a couple of adjustments to the patch to make my compiler happy.
In the ipmi_smi_watcher_register() routine, I deleted the "&" on
to_deliver; also, I added GFP_KERNEL as a second arg to kmalloc:
int ipmi_smi_watcher_register(struct ipmi_smi_watcher *watcher)
{
ipmi_smi_t intf;
- struct list_head to_deliver = LIST_HEAD_INIT(&to_deliver);
+ struct list_head to_deliver = LIST_HEAD_INIT(to_deliver);
struct watcher_entry *e, *e2;
mutex_lock(&ipmi_interfaces_mutex);
list_for_each_entry_rcu(intf, &ipmi_interfaces, link) {
if (intf->intf_num == -1)
continue;
- e = kmalloc(sizeof(*e));
+ e = kmalloc(sizeof(*e), GFP_KERNEL);
if (!e)
goto out_err;
e->intf_num = intf->intf_num;
list_add_tail(&e->link, &to_deliver);
}
I ran it on my 2-node system and it seemed to work as well as the
previous table-oriented patched version (e.g. great! :-). I'm still
working on getting an 8-node to test it on -- hopefully I'll get one
next week.
Thanks very much again, :-)
Carol Hebert
On Thu, 2006-10-19 at 16:23 -0500, Corey Minyard wrote:
> Ok, patch is attached.
>
> Carol Hebert wrote:
> > On Wed, 2006-10-18 at 13:37 -0700, Carol Hebert wrote:
> >
> >> Hi Corey,
> >>
> >> This latest patch worked great on my 2-node system! :-D I'll try to
> >> get some time on a 4-node and 8-node system asap to test it out on them
> >> as well.
> >>
> >
> > Oops, I guess I'll probably need that patch you were talking about
> > earlier to increase the number of supported nodes to > 4 to test the
> > 8-node system properly. :-} I think you mentioned changing the table
> > to a list to be able to support an arbitrary number of devices? I was
> > wondering if you had any idea when you might be able to get a chance to
> > make that change?
> >
> > Thanks again for all your help,
> >
> > Carol Hebert
> >
> >
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job
> > easier
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________
> > Openipmi-developer mailing list
> > Openipmi-developer@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/openipmi-developer
> >
>
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
