On Sat, 1 Aug 2026 01:03:59 GMT, Nir Lisker <[email protected]> wrote:
> Adds a section for button events and clarifies the existing sections. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). The new diagram is a nice addition (I am not sure if "DRAG_DETECTED" node should be a rhombus since it's a decision node (according to https://en.wikipedia.org/wiki/Flowchart ) The textual changes I like much less, mainly because the old one is more useful, in my opinion, since it describes what actually happens. modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java line 59: > 57: /// > 58: /// ## Button events > 59: /// A mouse button can be [pressed][#MOUSE_PRESSED] and > [released][#MOUSE_RELEASED]. A button [click][#MOUSE_CLICKED] it sounds like press-drag-release gesture might produce a `MOUSE_CLICKED` event. can you clarify? also, we probably should mention that the `MOUSE_CLICKED` arrives after the `MOUSE_RELEASED`, either here or in the `MOUSE_CLICKED` javadoc. modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java line 72: > 70: /// There are 3 types of drag gestures that can be chosen from within the > `DRAG_DETECTED` handler: > 71: /// > 72: /// 1. Simple press-drag-release (PDR), in which the source (picked) node > is the only node involved. It receives all the "node involved" is much more nebulous than "The whole press-drag-release gesture is delivered to one node ... If a mouse clicked event is generated from these events, it is still delivered to the same node." which actually describes what is happening. I really prefer the old description of the three types, as it is very clear, unlike the new one. Can we revert? ------------- PR Review: https://git.openjdk.org/jfx/pull/2238#pullrequestreview-4847111478 PR Review Comment: https://git.openjdk.org/jfx/pull/2238#discussion_r3706464448 PR Review Comment: https://git.openjdk.org/jfx/pull/2238#discussion_r3706987034
