On Tue, 4 Aug 2026 00:23:45 GMT, Nir Lisker <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java 
>> line 59:
>> 
>>> 57: ///
>>> 58: /// ## Button events
>>> 59: /// A mouse button can be [pressed][#MOUSE_PRESSED] and 
>>> [released][#MOUSE_RELEASED]. A button [click][#MOUSE_CLICKED]
>> 
>> it sounds like press-drag-release gesture might produce a `MOUSE_CLICKED` 
>> event.  can you clarify?
>> 
>> also, we probably should mention that the `MOUSE_CLICKED` arrives after the 
>> `MOUSE_RELEASED`, either here or in the `MOUSE_CLICKED` javadoc.
>
>> it sounds like press-drag-release gesture might produce a `MOUSE_CLICKED` 
>> event. can you clarify?
> 
> Both simple PDR and full-PDR can produce `MOUSE_CLICKED`. Do you want me to 
> explicitly state it? In the section about drag events, it's shown that both 
> end with a release event, so it is implied that it produces a click, but I 
> can add that info.

1. click: "A button click occurs after these happen" -> "may follow 
MOUSE_RELEASED" to be specific.  I recall at some point I thought it was 
press->click->release.

2. there is no `MOUSE_CLICKED` in your diagram, plus I can't  figure out how a 
click can be generated during the drag operation.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2238#discussion_r3714812780

Reply via email to