On Tue, 4 Aug 2026 00:33:09 GMT, Nir Lisker <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/input/MouseEvent.java
>> line 72:
>>
>>> 70: /// There are 3 types of drag gestures that can be chosen from within
>>> the `DRAG_DETECTED` handler:
>>> 71: ///
>>> 72: /// 1. Simple press-drag-release (PDR), in which the source (picked)
>>> node is the only node involved. It receives all the
>>
>> "node involved" is much more nebulous than "The whole press-drag-release
>> gesture is delivered to one node ... If a mouse clicked event is generated
>> from these events, it is still delivered to the same node." which actually
>> describes what is happening.
>>
>> I really prefer the old description of the three types, as it is very clear,
>> unlike the new one.
>>
>> Can we revert?
>
> I fixed the "involved" wording be removing it - the next sentence is specific
> ("receives all the events in the PDR gesture").
>
> The sentence "If a mouse clicked event is generated from these events, it is
> still delivered to the same node." is in the next sentence "...including
> button events even when they occur over other nodes."
>
> The old description is even lacking as it doesn't say that `MOUSE_RELEASED`
> events are also delivered to the node. Interestingly, `MOUSE_PRESSED` events
> are not generated, I wonder if this is a bug or intended.
I think the main issue I have with the new version is that it removed some
information that I feel is important.
for example:
- The whole press-drag-release gesture is **delivered to one node** (removed)
- and all subsequent mouse events are delivered to **that same node** until the
button is released.
- If these nodes need to be involved in the gesture, full press-drag-release
gesture **has to be activated.** (instructs what the app dev is supposed to do)
Also, in the new version:
- DRAG_DETECTED handler: what handler? are you referring to some internal
entity?
I think the old Dnd section is much more informative and easier to understand.
Please keep in mind that this is just my opinion, let's see what other people
think.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2238#discussion_r3714905533
