On Mon, 3 Aug 2026 19:20:07 GMT, Andy Goryachev <[email protected]> wrote:
> The new diagram is a nice addition (I am not sure if "DRAG_DETECTED" node > should be a rhombus since it's a decision node (according to > https://en.wikipedia.org/wiki/Flowchart ) I didn't follow any convention. If it matters, I can adjust the shapes. I assumed it would be clear after reading that section. > The textual changes I like much less, mainly because the old one is more > useful, in my opinion, since it describes what actually happens. I found the old ones to be confusing at best. Some specifics: * The methods that start the different drag gestures are not written in the description of each of them; they first appear in the summary, which should be... a summary, not add new information. * The summary is long compared to the paragraphs that describe the drag gestures - it's longer than the descriptions of full-PDR and DnD combined. A summary should be short (I turned it into a table). * The paragraph that describes full-PDR doesn't start with talking about full-PDR, it continues with (simple) PDR: "During a simple press-drag-release gesture, the other nodes are not involved and don't get any events." (which repeats "The whole press-drag-release gesture is delivered to one node." from its own paragraph). It's not clear that it's supposed to introduce another gesture type. * The second paragraph also doesn't say that this is the second gesture type, you get to the DnD paragraph and it starts with "The third gesture type"; where was the second? * The DnD paragraph is very terse and doesn't give an example of what it could be used for, unlike the previous paragraphs. Which lines that describe "what actually happens" are missing? It's probably easier to just add them than just revert. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2238#issuecomment-5173013085
