On Mon, 17 Aug 2026 16:55:49 GMT, Kevin Rushforth <[email protected]> wrote:

>> what do you mean?
>> 
>> https://github.com/openjdk/jfx/pull/2217/changes#diff-bdee521c329d386e86fab0d6870c31750481dddb7cb5ca6aa65854948ca649f8R379
>> 
>> we must document the parameters (and exceptional cases like no visible 
>> range).
>
> The parameters here are _input parameters_. As Alex says, there aren't any 
> (unlike the `BOUNDS_FOR_RANGE` attribute where there are).

I don't understand - it does not matter what kind of parameters they are, they 
need to be documented.  How am I supposed to provide VISIBLE_ITEM_RANGE in 
RichTextArea?

`ListViewSkin` L386 returns the `int[]` with `{ firstIndex, count }` which 
needs to be documented.  

Specifically,
- `int[] { firstIndex, count }` must be documented
- `int[] { 0, 0 }` case must be documented
- the fact that it is a non-null int[2] should probably be mentioned

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3797733600

Reply via email to