On Wed, 2 Sep 2026 09:31:59 GMT, Ambarish Rapte <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove dirty merge artifact > > gradle-local.properties.template line 31: > >> 29: # when building JavaFX. Any settings you configure in the >> gradle-local.properties # >> 30: # file will have precedence over any values specified in the build >> script itself. # >> 31: # Don't place Gradle properties (org.gradle.*) or system properties >> (systemProp.*) # > > Gradle properties (org.gradle.*) or system properties (systemProp.*): > Developers can mistakenly add such properties to this file and fail to read > this note, and the struggle to root cause it. > > Would it be convenient to add a warning or fail the build in > `loadLocalProperties` function, if such properties are added ? Good idea. I added a build failure to be on the safe side. Can reduce to logging a warning if others think otherwise. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2240#discussion_r3913186583
