On Wed, 2 Sep 2026 10:45:12 GMT, Kevin Rushforth <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> build.gradle line 330:
>
>> 328:
>> 329: loadProperties("$projectDir/build.properties")
>> 330: loadLocalProperties("$projectDir/gradle-local.properties")
>
> Question: loadProperties and loadLocalProperties are semantically different.
> The former is used for loading `build.properties` and turns dot-separated
> names into camel-case names, so `jfx.build.jdk.version` becomes
> `jfxBuildJdkVersion`. The latter leaves the names unchanged. Do you think it
> is worth adding a comment to that effect to the new method (and. maybe the
> existing method as well)?
I think it's more of an implementation detail and I'd say it's a discrepancy in
the properties files rather than in the implementation. Why does
`build.properties` use lowercase dotted names while the local properties one
uses uppercase underscore names?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2240#discussion_r3913855761
