On Wed, 2 Sep 2026 12:03:14 GMT, Nir Lisker <[email protected]> wrote:
>> build.gradle line 330:
>>
>>> 328:
>>> 329: loadProperties("$projectDir/build.properties")
>>> 330: loadLocalProperties("$projectDir/gradle-local.properties")
>>
>> Question: loadProperties and loadLocalProperties are semantically different.
>> The former is used for loading `build.properties` and turns dot-separated
>> names into camel-case names, so `jfx.build.jdk.version` becomes
>> `jfxBuildJdkVersion`. The latter leaves the names unchanged. Do you think it
>> is worth adding a comment to that effect to the new method (and. maybe the
>> existing method as well)?
>
> I think it's more of an implementation detail and I'd say it's a discrepancy
> in the properties files rather than in the implementation. Why does
> `build.properties` use lowercase dotted names while the local properties one
> uses uppercase underscore names?
The main reason is historical -- our initial build system was ant-based. The
`build.properties` file, along with similar closed property files are parsed by
more than just gradle (e.g., closed shell scripts). We could consider an RFE to
change it, but it would require a coordinated open/closed change along with
making sure we don't have any other place that uses it.
Anyway, I think it's OK to leave it undocumented.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2240#discussion_r3916862042
