On Wed, 2 Sep 2026 10:37:53 GMT, Nir Lisker <[email protected]> wrote:
>> Allows using a Gradle properties file at the project level by requiring the >> user-specific one to be present in the user's Gradle dir. A Gradle >> properties file is necessary for a proper Gradle build system's >> configuration. The user file takes precedence over the project one. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments Looks good with a couple minor points. Regarding the reported reference to `gradle.properties`, it is unused by the build -- Xcode is only possibly used by a developer when debugging on macOS. I suspect this script is unused -- and in any case the JDK 8 fallback would completely break. @sashamatveev can say whether he uses this script in media in connection with Xcode. build.gradle line 330: > 328: > 329: loadProperties("$projectDir/build.properties") > 330: loadLocalProperties("$projectDir/gradle-local.properties") Question: loadProperties and loadLocalProperties are semantically different. The former is used for loading `build.properties` and turns dot-separated names into camel-case names, so `jfx.build.jdk.version` becomes `jfxBuildJdkVersion`. The latter leaves the names unchanged. Do you think it is worth adding a comment to that effect to the new method (and. maybe the existing method as well)? ------------- PR Review: https://git.openjdk.org/jfx/pull/2240#pullrequestreview-5080235214 PR Review Comment: https://git.openjdk.org/jfx/pull/2240#discussion_r3913271686
