On Fri, 17 Jul 2026 11:48:11 GMT, Marius Hanl <[email protected]> wrote:
>> ### Fix >> The PR replaces applyCss() with reapplyCSS in the nodeOrientation code of >> Scene. >> applyCss() reapplied styles eagerly - and didn't rebuild the "style maps" >> resulting in wrong css. >> reapplyCSS() rematches correctly - and also defers it to the next pulse. >> >> I've added a unit test to: Node_effectiveOrientation_Css_Test. >> >> ### Test improvements >> Because the whole test class was disabled, I've also investigated which >> tests are working - and reenabled the working tests. >> This PR also fixes 2 of the previously failing tests in >> Node_effectiveOrientation_Css_Test - which are now enabled. >> >> Which are the following tests: >> >> Node_effectiveOrientation_Css_Test.test_dir_pseudoClass_functions_on_scene_effective_orientation_not_node >> Node_effectiveOrientation_Css_Test.test_SimpleSelector_dir_pseudoClass_with_scene_effective_orientation_rtl >> >> >> >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > modules/javafx.graphics/src/test/java/test/javafx/scene/Node_effectiveOrientation_Css_Test.java > line 167: > >> 165: @Disabled("JDK-8234152") >> 166: @Test >> 167: public void >> test_CompounSelector_dir_pseudoClass_on_child_with_scene_effective_orientation_ltr() >> { > > While here, can we fix the typo in `test_Compoun` -> `test_Compound` here and > some other tests aswell Fixed the 2 Compun - couldn't find another spelling error. > modules/javafx.graphics/src/test/java/test/javafx/scene/Node_effectiveOrientation_Css_Test.java > line 244: > >> 242: >> 243: @Test >> 244: public void testCssUpdates() { > > Maybe we should name it similar as what you wrote in your description - maybe > `testChangeNodeOrientationWillReapplyCss` or > `testChangeNodeOrientationWillBatchReapplyCss` It's now named testChangeNodeOrientationWillReapplyCss. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2213#discussion_r3636343874 PR Review Comment: https://git.openjdk.org/jfx/pull/2213#discussion_r3636344820
