On Wed, 15 Jul 2026 09:54:42 GMT, Florian Kirmaier <[email protected]> wrote:
> ### Fix > The PR replaces applyCss() with reapplyCSS in the nodeOrientation code of > Scene. > applyCss() reapplied styles eagerly - and didn't rebuild the "style maps" > resulting in wrong css. > reapplyCSS() rematches correctly - and also defers it to the next pulse. > > I've added a unit test to: Node_effectiveOrientation_Css_Test. > > ### Test improvements > Because the whole test class was disabled, I've also investigated which tests > are working - and reenabled the working tests. > This PR also fixes 2 of the previously failing tests in > Node_effectiveOrientation_Css_Test - which are now enabled. > > Which are the following tests: > > Node_effectiveOrientation_Css_Test.test_dir_pseudoClass_functions_on_scene_effective_orientation_not_node > Node_effectiveOrientation_Css_Test.test_SimpleSelector_dir_pseudoClass_with_scene_effective_orientation_rtl > > > > > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This seems like a relatively safe fix on the surface, but we will not have time to adequately review it before the `jfx27` RDP1 fork. Since it touches CSS and since you have a somewhat related PR #2215 also out for review, it seems better to target this for `jfx28` anyway. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2213#issuecomment-4981370112
