On Mon, 21 Sep 2026 21:23:08 GMT, Andy Goryachev <[email protected]> wrote:
>> Florian Kirmaier has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'refs/remotes/origin/master' into
>> JDK-8388304-fix-scene-nodeorientation
>> - 8388304: fixed spelling and test-name
>> - 8388304: Scene.setNodeOrientation does not update :dir() styles
>>
>> Replace applyCss() with reapplyCSS() in the nodeOrientation invalidation:
>> applyCss() reapplied styles eagerly without rebuilding style maps, leaving
>> :dir() matches stale. reapplyCSS() re-matches and defers to the next
>> pulse.
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/Node_effectiveOrientation_Css_Test.java
> line 247:
>
>> 245: Group root = new Group();
>> 246: Scene scene = new Scene(root);
>> 247: Stage stage = new Stage();
>
> this stage is leaking (never hidden etc.)
> should probably use the class field instead
> `Node_effectiveOrientation_Css_Test.stage` ?
You are right. It nor properly reuses the part from @BeforeAll.
> modules/javafx.graphics/src/test/java/test/javafx/scene/Node_effectiveOrientation_Css_Test.java
> line 273:
>
>> 271: assertEquals(Color.web("#00ff00"), rect.getFill());
>> 272: }
>> 273:
>
> extra newline
newline removed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2213#discussion_r4072335419
PR Review Comment: https://git.openjdk.org/jfx/pull/2213#discussion_r4072337480
