On Thursday 14 May 2009, Zach Welch wrote: > If anyone knows of patches that have not been applied, please reply here > with a link into the mailing list archives to the last version posted:
https://lists.berlios.de/pipermail/openocd-development/2009-May/006282.html .... but here's a tweaked version of that patch. I'd also like to see a brief update about why this list adopts the unusual "send as an attachment" policy. Generally attachments get discouraged ... since they are harder to review by the normal "press reply, trim excess, add in-line comments" techniques. - Dave
--- PATCHES | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-) --- a/PATCHES +++ b/PATCHES @@ -1,28 +1,45 @@ Please mail patches to: -openocd-developm...@lists.berlios.de + openocd-development@lists.berlios.de -The patch should be against svn trunk using an SVN -diff. +Note that you can't currently send patches to that list unless +you're a member, although the list info page may say otherwise. -Attach the patch to the email as a .txt file and -also write a short change log entry that maintainers -can copy and paste into the commit message +The patch should be against svn trunk using an SVN diff. +If you use git-svn, a git diff or patch is OK too; likewise +a quilt patch, if you use quilt. + +It should be a "good patch": focus it on a single issue, and +make it be easily reviewable. Don't make it so large that it's +hard to review; split large patches into smaller ones. (That +can also help track down bugs later on.) All patches should be +"clean", which includes preserving the existing coding style and +updating documentation as needed. + +Attach the patch to the email as a .txt file and also write +a short change log entry that maintainers can copy and paste +into the commit message (although though many just include +the $SUBJECT). + +Say if it's a bugfix (describe the bug) or a new feature. +Don't expect patches to merge immediately for the next release. +Be ready to rework patches in response to feedback. Add yourself to the GPL copyright for non-trivial changes. To create a patch from the command line: -svn diff >mypatch.txt + svn diff >mypatch.txt -http://svnbook.red-bean.com/en/1.0/re09.html +See: -NB! remember to use "svn add" on new files first! + http://svnbook.red-bean.com/en/1.0/re09.html -http://svnbook.red-bean.com/en/1.0/re01.html +NB! remember to use "svn add" on new files first! + http://svnbook.red-bean.com/en/1.0/re01.html If you have a decent SVN GUI, then that should be able to create and apply patches as well... - \ No newline at end of file +
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
