-----Original Message----- From: Chris Marshall
Sent: Friday, April 28, 2017 9:59 PM
To: [email protected] ; perldl
Subject: Re: [Pdl-general] PDL "bitrot-fix" update

Hi Rob-

The fix for @INC is already in the current git.

Oh, yeah ... it probably makes better sense to test the git version than the stable release.

So, of course, this time I'm testing by running 'perl Makefile.PL', 'make', etc. And I find that there are additional changes needed to some of the files in Basic/Core - see attached Core-diff.txt.

But most (if not all) of that code that the patch changes was present in PDL-2.017 .... so why didn't it blow up when I built 2.017 with the exact same build of perl 5.25.12 (by running 'cpan -i PDL') an hour ago ??

Is CPAN.pm doing something to subvert these new oh-so-crucial security measures ??

Now I don't know what's going on.
(When I ran 'git pull' it updated to commit d8df2ed24b74ffd6a5cfdd9c605266a4415950f9. I suppose that's current.)

Cheers,
Rob

--- Core.xs_orig        2017-04-28 22:30:50 +1000
+++ Core.xs     2017-04-28 22:32:20 +1000
@@ -336,7 +336,7 @@

# using "perl" not $^X because that doesn't work on "perl in space"
# TODO: switching back to $^X since using "perl" is not a viable fix
-INCLUDE_COMMAND: $^X -e "require q{Dev.pm};
PDL::Core::Dev::generate_core_flags()"
+INCLUDE_COMMAND: $^X -e "require q{./Dev.pm};
PDL::Core::Dev::generate_core_flags()"

#if 0
=begin windows_mmap
--- pdl.h.PL_orig       2017-04-28 22:23:20 +1000
+++ pdl.h.PL    2017-04-28 22:24:59 +1000
@@ -6,7 +6,7 @@
use File::Basename qw(&basename &dirname);

# how many variable types (ie PDL_Byte, ...) are there?
-require 'Types.pm';
+require './Types.pm';
my $ntypes = $#PDL::Types::names;
my $PDL_DATATYPES = PDL::Types::datatypes_header();

--- pdlconv.c.PL_orig   2017-04-28 22:34:31 +1000
+++ pdlconv.c.PL        2017-04-28 22:35:12 +1000
@@ -7,9 +7,9 @@
use Config;
use File::Basename qw(&basename &dirname);

-require 'Dev.pm'; PDL::Core::Dev->import;
+require './Dev.pm'; PDL::Core::Dev->import;
use vars qw( %PDL_DATATYPES );
-require 'Types.pm'; #for typesrtkeys
+require './Types.pm'; #for typesrtkeys

# This forces PL files to create target in same directory as PL file.
# This is so that make depend always knows where to find PL derivatives.
--- pdlcore.c.PL_orig   2017-04-28 22:32:53 +1000
+++ pdlcore.c.PL        2017-04-28 22:34:02 +1000
@@ -6,7 +6,7 @@
use Config;
use File::Basename qw(&basename &dirname);

-require 'Dev.pm'; PDL::Core::Dev->import;
+require './Dev.pm'; PDL::Core::Dev->import;
use vars qw( %PDL_DATATYPES );

# check for bad value support
@@ -14,7 +14,7 @@
die "No PDL::Config found" unless %PDL::Config;
my $bvalflag = $PDL::Config{WITH_BADVAL};
my $usenan = $PDL::Config{BADVAL_USENAN};
-require 'Types.pm';
+require './Types.pm';
PDL::Types->import(':All');


--- pdlcore.h.PL_orig   2017-04-28 22:26:48 +1000
+++ pdlcore.h.PL        2017-04-28 22:28:01 +1000
@@ -11,7 +11,7 @@
use Config;
use File::Basename qw(&basename &dirname);

-require 'Dev.pm'; PDL::Core::Dev->import;
+require './Dev.pm'; PDL::Core::Dev->import;
use vars qw( %PDL_DATATYPES );

# version 2 is for versions after PDL 2.1.1
@@ -349,7 +349,7 @@

    # fortunately it looks like Types.pm.PL is processed before this
    # file
-    require "Types.pm";  # ie PDL::Types
+    require "./Types.pm";  # ie PDL::Types

for (PDL::Types::typesrtkeys()) {
   my $ctype = $PDL::Types::typehash{$_}{ctype};
--- pdlsimple.h.PL_orig 2017-04-28 22:29:15 +1000
+++ pdlsimple.h.PL      2017-04-28 22:29:45 +1000
@@ -3,7 +3,7 @@
use Config;
use File::Basename qw(&basename &dirname);

-require 'Types.pm';
+require './Types.pm';
my $PDL_DATATYPES = PDL::Types::datatypes_header();

# List explicitly here the variables you want Configure to
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
pdl-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pdl-general

Reply via email to