Jeff Davis wrote: > On Mon, 2013-06-10 at 11:38 -0400, Tom Lane wrote: > > The thing I'm not too happy about is having to copy the checksum code > > into pg_filedump. We just got rid of the need to do that for the CRC > > code, and here it is coming back again. Can't we rearrange the core > > checksum code similarly to what we did for the CRC stuff recently, > > so that you only need access to a .h file for it? > > The CRC implementation is entirely in header files. Do you think we need > to go that far, or is it fine to just put it in libpgport and link that > to pg_filedump?
If a lib is okay, use libpgcommon please, not libpgport. But I think a .h would be better, because there'd be no need to have a built source tree to build pg_filedump, only the headers installed. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
