Jeff Davis <pg...@j-davis.com> writes: > I have a question about the commit though: shouldn't both functions be > static if they are in a .h file? Otherwise, it could lead to naming > conflicts. I suppose it's wrong to include the implementation file > twice, but it still might be confusing if someone tries. Two ideas that > come to mind are: > * make both static and then have a trivial wrapper in checksum.c > * export one or both functions, but use #ifndef CHECKSUM_IMPL_H to > prevent redefinition
Ah, you are right, I forgot the #ifndef CHECKSUM_IMPL_H dance. Will fix in a bit. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers