On 27 October 2016 at 00:42, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Oct 26, 2016 at 7:17 AM, Andres Freund <and...@anarazel.de> wrote: >> On 2016-09-23 16:04:32 -0400, Tom Lane wrote: >>> Looking back over the thread, I see that you also proposed installing >>> isolationtester and pg_isolation_regress for the benefit of extensions. >>> I'm very much less excited about that idea. It'd be substantially more >>> dead weight in typical installations, and I'm not sure that it'd be useful >>> to common extensions, and I'm not eager to treat isolationtester's API >>> and behavior as something we need to hold stable for extension use. >> >> FWIW, I'd be quite happy if it were installed. Running isolationtester >> when compiling extensions against distribution postgres packages would >> be quite useful. > > +1.
Patch attached. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
From 40735041753c48d282f3af58482992b8da00c96d Mon Sep 17 00:00:00 2001 From: Craig Ringer <cr...@2ndquadrant.com> Date: Mon, 14 Nov 2016 14:51:09 +0800 Subject: [PATCH] Install isolationtester Per discussion in <ca+tgmoz2sht38lwkxj0yj0t3yqebhw6jhtwoypqh2rtc0vj...@mail.gmail.com> --- src/Makefile | 1 + src/test/isolation/Makefile | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/src/Makefile b/src/Makefile index 977f80b..d4aa06b 100644 --- a/src/Makefile +++ b/src/Makefile @@ -27,6 +27,7 @@ SUBDIRS = \ pl \ makefiles \ test/regress \ + test/isolation \ test/perl # There are too many interdependencies between the subdirectories, so diff --git a/src/test/isolation/Makefile b/src/test/isolation/Makefile index 3d272d5..613309e 100644 --- a/src/test/isolation/Makefile +++ b/src/test/isolation/Makefile @@ -66,3 +66,12 @@ installcheck-prepared-txns: all temp-install check-prepared-txns: all temp-install ./pg_isolation_regress --temp-instance=./tmp_check $(TEMP_CONF) $(EXTRA_REGRESS_OPTS) --inputdir=$(srcdir) --schedule=$(srcdir)/isolation_schedule prepared-transactions + +install: all installdirs + $(INSTALL_PROGRAM) isolationtester$(X) '$(DESTDIR)$(pgxsdir)/$(subdir)/isolationtester$(X)' + +installdirs: + $(MKDIR_P) '$(DESTDIR)$(pgxsdir)/$(subdir)' + +uninstall: + rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/isolationtester$(X)' -- 2.5.5
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
