Re: [HACKERS] Beta2 Tag'd and Bundled ...

[Larry Rosenman]

--On Saturday, August 30, 2003 00:35:10 -0300 "Marc G. Fournier" <[EMAIL PROTECTED]> wrote:

On Fri, 29 Aug 2003, Larry Rosenman wrote:

--On Saturday, August 30, 2003 00:19:49 -0300 "Marc G. Fournier"
<[EMAIL PROTECTED]> wrote:

>
>> So be it, but I was under the impression that the fix would be
>> committed shortly after I posted it on LAST SATURDAY, but apparently
>> Bruce was out of town, and the Beta2 TAG was laid, WITHOUT PUBLIC
>> NOTICE about the TAG coming.
>
> Beta2 TAG was laid so that we could wrap up all fixes to date, of which
> yours for unixware hadn't been included yet ... it had been 3 weeks
> since Beta1, there were alot of changes, and if ppl are testing based
> on the tar ball and not straight CVS, chances are most bugs reported
> had already been fixed ...
>
>> Then the SCO/IBM/RED HAT lawsuits are thrown in my face for
>> complaining about these facts.
>
> This was uncalled for, but so were your comments over one patch ...
>
>> I want to see PostgreSQL succeed and take over the Open Source
>> DataBase world, and want to help, but y'all are making it HARD.
>
> Because one patch wasn't committed before we tar'd up a new beta?
no, because the SCO/IBM/RED HAT lawsuits keep getting thrown in my face
everytime I ask for UnixWare specific changes.

'K, since flamewars are just sooooo counter-productive to the task at
hand, can we just drop this and move on?

Larry, can you go to archives and let us know which URL contains the patch
that seems to be 'in question'?  And post it in a seperate thread, so that
it doesn't get lost in this whole degraded thread?

Here is the patch as posted again (the src/template/unixware change will need minor
mods for today's CVS).

Index: src/port/thread.c
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/port/thread.c,v
retrieving revision 1.4
diff -u -r1.4 thread.c
--- src/port/thread.c 16 Aug 2003 15:35:51 -0000 1.4
+++ src/port/thread.c 23 Aug 2003 04:29:15 -0000
@@ -68,7 +68,7 @@
pqGetpwuid(uid_t uid, struct passwd *resultbuf, char *buffer,
size_t buflen, struct passwd **result)
{
-#if defined(USE_THREADS) && defined(NEED_REENTRANT_FUNC_NAMES)
+#if defined(USE_THREADS) && (defined(NEED_REENTRANT_FUNC_NAMES) || defined(HAVE_GETPWUID_R))
/*
* Early POSIX draft of getpwuid_r() returns 'struct passwd *'.
* getpwuid_r(uid, resultbuf, buffer, buflen)
Index: src/template/unixware
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/template/unixware,v
retrieving revision 1.15
diff -u -r1.15 unixware
--- src/template/unixware 16 Aug 2003 15:35:51 -0000 1.15
+++ src/template/unixware 23 Aug 2003 04:29:15 -0000
@@ -10,5 +10,5 @@
fi

SUPPORTS_THREADS=yes
-NEED_REENTRANT_FUNC_NAMES=yes
-THREAD_CFLAGS += -D_REENTRANT
+#NEED_REENTRANT_FUNC_NAMES=yes
+THREAD_CFLAGS="$THREAD_CFLAGS -D_REENTRANT -DHAVE_GETPWUID_R"

--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: [EMAIL PROTECTED]
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

unixware.patch.2
Description: Binary data

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
    (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])