> Makefile:
>
> - line 146: This script is rather un-makefiley. Perhaps something like
Agreed.
> Of course, if it stays in SUNWckr from 84 on, then the default above
> will be wrong. Perhaps it should default to SUNWckr, and the known set
> of builds where it's in SUNWcakr.i should be explicit.
I'm inclined to do the latter and I'll put entries in for the older
builds (I think the pre-75a builds are broken in other ways at the
moment but I'll put them in for now.)
> Why do you have 83a at all now?
Actually, I'll remove that now as it was an artifact when I wasn't sure
whether 83a would be putback or not. Since the directory doesn't
exist, it doesn't make sense to keep it.
> svc-dlmgmtd:
>
> - line 42: this now doesn't test the result of dlmgmtd, but of the ppriv
> command.
Good catch. This now looks like
/sbin/dlmgmtd
status=$?
ppriv -s A+file_dac_read,file_dac_execute $(pgrep dlmgmtd)
if [ $status = 0 ]; then
> SUNWgnome-media-mp3.84:
>
> - is there a bug filed against the inability to remove packages on
> upgrade?
I thought for sure that such a bug was filed but didn't see one so I've
filed
820 Need a way to obsolete packages
> I think for my own sanity in future reviews I'm going to have to fix
> solaris.py to search for include files from a list of directories; this
> .build thing, with lines whizzing around all over the place is getting
> craaazy. (Feel free to say you told me so. :)
I told you^H^H^H^H^H^H^H^H^H^HThanks, I look forward to reviewing what
you come up with. :-)
dsc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
