Danek Duvall wrote:
> I finally sat down to look at bug 387 and discovered that it was a
> relatively easy fix, so here it is:
> 
>     http://cr.opensolaris.org/~dduvall/pkg-bug387/

http://cr.opensolaris.org/~dduvall/pkg-bug387/src/client.py.wdiff.html
==========
       590 +        except imageplan.NonLeafPackageException, e:
       591 +                error("""\nCannot remove '%s' due to
       592 +the following packages that directly depend on it:""" % e[0])
       593 +                for d in e[1]:
       594 +                        msg("  %s" % d)

Given that you use error to print the first part of the message (which 
in turn calls emsg to print to stderr), it seems that emsg() should be 
used to print the rest of it instead of msg() so that it will go to 
stderr as well.

Your changes look good otherwise.

> With this change, the testsuite runs cleanly again (well, aside from the
> memleaks testing).

Greatly appreciated.

-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to