On Wed, Jul 23, 2008 at 01:19:47PM -0700, Brock Pytlik wrote:

> Should we have test cases for other kinds of dependencies to help ensure 
> correct behavior in the future?

Probably.  Not this wad.

> It's not clear to me why we're printing the messages on lines 328 and 331 
> of imageplan.py.

Nor to me.  Perhaps they're just surviving debug statements.  A lot of the
removal code is really old and crufty at this point.

> Is there any thought that we might want to update the progress tracker 
> around lines 334, 334 in imageplan.py?

That's a great idea.  That uncovered a pretty bad performance problem which
I've fixed at least partly, but now I've got a couple of other issues that
I at least need to think about.  :-/

I hope to have another webrev out tomorrow.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to