Danek Duvall wrote: >> I hope to have another webrev out tomorrow. > > http://cr.opensolaris.org/~dduvall/pkg-bug387-2/ > > with the incremental at > > http://cr.opensolaris.org/~dduvall/pkg-bug387-1-2/ > > I removed the odd print statements Brock noticed, added progresstracker > calls (it seems mostly smooth now, but someone check to make sure I'm not > doing something totally stupid there), and am now caching the result of the > dependency search, as reading all of the manifests a zillion times (when > removing, say, SUNWcsl) takes ... a little while.
http://cr.opensolaris.org/~dduvall/pkg-bug387-2/src/modules/client/image.py.wdiff.html ========== 867 + self.__req_dependents = {} Shouldn't this be done in __init__ instead or in both places? Otherwise, your changes look fine. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
