On Fri, Jul 25, 2008 at 12:22:28PM -0500, Shawn Walker wrote: > http://cr.opensolaris.org/~dduvall/pkg-bug387-2/src/modules/client/image.py.wdiff.html > ========== > > 867 + self.__req_dependents = {} > > Shouldn't this be done in __init__ instead or in both places?
I debated about that. Doing it this way keeps the variable only in these two methods, which means we needn't even instantiate the dictionary unless we end up doing a recursive removal. It doesn't matter that much one way or another, this just seemed a bit cleaner to me, but if there's consensus that we do this sort of thing in the constructor, it's an easy change. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
