Danek Duvall wrote: > I finally sat down to look at bug 387 and discovered that it was a > relatively easy fix, so here it is: > > http://cr.opensolaris.org/~dduvall/pkg-bug387/ > > With this change, the testsuite runs cleanly again (well, aside from the > memleaks testing). > > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > In general looks good. A few questions/nits. Should we have test cases for other kinds of dependencies to help ensure correct behavior in the future?
It's not clear to me why we're printing the messages on lines 328 and 331 of imageplan.py. Is there any thought that we might want to update the progress tracker around lines 334, 334 in imageplan.py? I'm worried that doing a recursive remove on a package with a lot of dependencies (especially if the recursive stack gets large) will appear to the user to have hung since the spinner won't be moving. Those are my only concerns. Looks like a good change. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
