Back on 8/8, I submitted the two code reviews below. I got some comments on the first one from Shawn (Thanks, Shawn), but haven't heard anything else on these. I merged them with the gate again, and have reposted the CR for the first one with the changes (the second one didn't require any changes due to the merge).
First review: Image properties and UUIDs for image authorities Issues: http://defect.opensolaris.org/bz/show_bug.cgi?id=856 http://defect.opensolaris.org/bz/show_bug.cgi?id=1347 http://defect.opensolaris.org/bz/show_bug.cgi?id=2307 Webrev: http://cr.opensolaris.org/~tmueller/cr-856,1347,2307-2/ These issues are for the image UUID and image properties features, plus a minor bug fix. After the comments that were received from previous code reviews and a discussion with Stephen about the UUID and image properties features, the following changes to the design have been implemented: Image properties: - replace policies with properties (policies are just boolean properties). - old policies are read from the cfg_cache file correctly and moved to the [property] section - since policies are now properties, policies will be able to be set using the pkg set-property command UUID: - A UUID is always set for each authority - A new image-wide policy, send-uuid, is introduced to control whether the UUIDs for authorities are sent. Default value: false. - The reset-uuid option is retained on set-authority to allow an installer or other software that copies an image to change the UUID. Second review: port_available problems on Windows and Mac/OS I've changed the implementation of this fix to avoid a misinterpretation of an EINVAL return code. The solution now puts a separate try block around the connect call and catches EINVAL there, retrying the call with a non-blocking socket if it sees one. A new webrev has been posted here: http://cr.opensolaris.org/~tmueller/cr-2695,2705-2/ Links to issues: http://defect.opensolaris.org/bz/show_bug.cgi?id=2695 http://defect.opensolaris.org/bz/show_bug.cgi?id=2705 Thanks. Tom _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
