On Mon, Aug 18, 2008 at 03:21:12PM -0500, Tom Mueller (pkg-discuss) wrote:
> http://cr.opensolaris.org/~tmueller/cr-856,1347,2307-2/
client.py:
- line 1433: if you're creating an authority with this call to
set-authority, and you don't explicitly pass --reset-uuid, a uuid
doesn't get generated, and it doesn't appear to in img.set_authority(),
either. I thought that a uuid would always be attached to an
authority.
- line 1565-1570: Try this:
try:
propname, propvalue = pargs
except ValueError:
usage( ... )
- line 1588: you need some message here to indicate what the user did
wrong.
- line 1587: just "if not pargs"
- line 1590: I think it'd be better either to validate all properties and
error out if one doesn't exist before unsetting them, or to remove all
properties you can, and list the ones that didn't exist at the end.
The latter is probably better, as you can just utilize the KeyError you
get by trying to delete a non-existent property.
- line 1615, 1619: please find the widest property name instead of
hardcoding 35.
- line 1616: "if pargs"
pkg.5.txt:
- line 353: strike "using pkg(1)"
filelist.py:
- line 102: why not just the None object?
image.py:
- line 395: no spaces around equals here.
- line 485, 493: won't the dictionary access naturally raise a KeyError?
- line 497: strike "gen_". Perhaps just name the method "properties"?
- line 1650: why not a normal dictionary fetch, like on line 1049?
imageconfig.py:
- line 109: comment is not true -- it'll return the default policy.
- line 161: None object?
- line 188: this is decoding from utf-8 into the current default
encoding? What happens if that fails, because the default is 7-bit or
some other lame encoding?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
