On Fri, Sep 19, 2008 at 04:08:31PM -0500, Tom Mueller (pkg-discuss) wrote:
> http://cr.opensolaris.org/~tmueller/cr-uuid4
client.py:
- line 1797: I'm not sure that's the right thing to do. Perhaps you
could return 3 the way some of the other subcommands (refresh) do on
partial failure. Otherwise, 1 is better than 0, I think.
filelist.py:
- line 104: This still seems inconsistent with the other uses. Here you
have the string "None", but in Image.get_uuid(), you return the None
object if we're not supposed to send it, and in versioned_urlopen(),
you perform a boolean test on the uuid parameter, not a comparison
against the "None" string.
image.py:
- line 505: I don't think we want this leakage of uuids. If we can't
find the authority, don't send a uuid.
- line 1166-1168: since you're already changing two of three lines here,
might as well get rid of the spaces around the equals signs. Same in
retrieve.py.
- line 1828-1831: try/catch
imageconfig.py:
- line 98-99: Use a generator expression instead of a list comprehension,
and the style
foo = dict((
thing
for thing in whatever
))
- line 112: no need for parens
- line 115: use a tuple
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
